Require min 1 confirmation in payment tier config.
Disallow minConfirmations: 0 for BTC and XMR tiers at startup validation, update env examples and deploy docs, and drop tx-detected UI copy and legacy tests.
This commit is contained in:
@@ -1,14 +1,14 @@
|
||||
import { resolveMinConfirmations } from './resolveMinConfirmations';
|
||||
|
||||
const tiers = [
|
||||
{ upToTotalFiat: '25', minConfirmations: 0 },
|
||||
{ upToTotalFiat: '25', minConfirmations: 1 },
|
||||
{ upToTotalFiat: '250', minConfirmations: 5 },
|
||||
{ minConfirmations: 10 }
|
||||
] as const;
|
||||
|
||||
describe('resolveMinConfirmations', () => {
|
||||
it('returns 0 for small orders (tx-detected tier)', () => {
|
||||
expect(resolveMinConfirmations(10, [...tiers])).toBe(0);
|
||||
it('returns the first tier for small orders', () => {
|
||||
expect(resolveMinConfirmations(10, [...tiers])).toBe(1);
|
||||
});
|
||||
|
||||
it('returns the middle tier for medium orders', () => {
|
||||
|
||||
@@ -35,14 +35,14 @@ describe('formatInvoicePaymentConfirmationStatus', () => {
|
||||
).toBe('2/10');
|
||||
});
|
||||
|
||||
it('treats zero-confirmation tiers as confirmed', () => {
|
||||
it('returns compact progress at zero confirmations', () => {
|
||||
expect(
|
||||
formatInvoicePaymentConfirmationStatus({
|
||||
confirmations: 0,
|
||||
requiredConfirmations: 0,
|
||||
requiredConfirmations: 3,
|
||||
format: 'compact'
|
||||
})
|
||||
).toBe('Confirmed');
|
||||
).toBe('0/3');
|
||||
});
|
||||
});
|
||||
|
||||
|
||||
@@ -1,9 +1,6 @@
|
||||
import { formatRelativeTimeAgo } from '../formatRelativeTimeAgo';
|
||||
import type { InvoicePaymentConfirmationStatusFormat } from './types/InvoicePaymentConfirmationStatusFormat';
|
||||
|
||||
const formatRequiredConfirmationsLabel = (requiredConfirmations: number): string =>
|
||||
requiredConfirmations === 0 ? '0 (tx-detected)' : String(requiredConfirmations);
|
||||
|
||||
export const formatInvoicePaymentConfirmationStatus = ({
|
||||
confirmations,
|
||||
requiredConfirmations,
|
||||
@@ -29,5 +26,5 @@ export const formatInvoicePaymentConfirmationStatus = ({
|
||||
return `${confirmations} / ${requiredConfirmations} confirmations · detected ${detectedAgo}`;
|
||||
}
|
||||
|
||||
return `${confirmations}/${formatRequiredConfirmationsLabel(requiredConfirmations)}`;
|
||||
return `${confirmations}/${requiredConfirmations}`;
|
||||
};
|
||||
|
||||
@@ -463,19 +463,6 @@ describe('toStorefrontInvoiceView', () => {
|
||||
statusVariant: 'confirmed'
|
||||
});
|
||||
});
|
||||
|
||||
it('treats tx-detected invoices as confirmed for payment status display', async () => {
|
||||
const payment = buildPayment({ confirmations: 0 });
|
||||
const invoice = buildInvoice({
|
||||
moneroDetails: buildMoneroDetails({ requiredConfirmations: 0 }),
|
||||
payments: [payment]
|
||||
});
|
||||
|
||||
const view = await toStorefrontInvoiceView(invoice);
|
||||
|
||||
expect(view.showRefresh).toBe(false);
|
||||
expect(view.payments[0].confirmationStatus).toBe('Confirmed');
|
||||
});
|
||||
});
|
||||
|
||||
describe('overpayment', () => {
|
||||
|
||||
Reference in New Issue
Block a user